Conversation
|
Your implementation doesn't actually differ from the string comparison in terms of efficiency, because Serde's Serialize/Deserialize uses strings, but not numbers. |
Author
Thanks for the suggestion. The recent commit should implement it. |
Jbziscool
approved these changes
Aug 14, 2023
Jbziscool
approved these changes
Nov 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request replaces the constants
DIRECTORYandFILEinsidesrc-tauri/src/filesystem/mod.rswith an enum calledFileTypeas suggested here #60. This is makes the code more idiomatic and improves efficiency as we are no longer storing an entirestrin memory.