feat(info, search, install, uninstall): add json output option #246
+251
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeroshade
requested review from
Mandukhai-Alimaa,
amoeba,
eitsupi,
esadek and
ianmcook
eitsupi
reviewed
Jan 11, 2026
amoeba
reviewed
Jan 11, 2026
Member
amoeba
left a comment
amoeba
left a comment
There was a problem hiding this comment.
Works great, nice one.
Two suggestions for style and we should also update the shell completions and docs.
Here's a patch for the docs,
diff --git a/docs/reference/cli.md b/docs/reference/cli.md
index 1137183..f8bb8b8 100644
--- a/docs/reference/cli.md
+++ b/docs/reference/cli.md
@@ -66,6 +66,10 @@ $ dbc search [FILTER]
<h3>Options</h3>
+`--json`
+
+: Print output as JSON instead of plaintext
+
`--verbose`, `-v`
: Enable verbose output
@@ -255,6 +259,10 @@ $ dbc info <DRIVER>
<h3>Options</h3>
+`--json`
+
+: Print output as JSON instead of plaintext
+
`--quiet`, `-q`
: Suppress all output
zeroshade
changed the title
amoeba
approved these changes
Jan 17, 2026
Member
amoeba
left a comment
amoeba
left a comment
There was a problem hiding this comment.
Is this ready for another review? I think this looks good now so +1.
eitsupi
reviewed
Jan 17, 2026
cmd/dbc/completions/dbc.bash
Outdated
| COMPREPLY=($(compgen -W "user system" -- "$cur")) | ||
| return 0 | ||
| ;; | ||
| ;; |
Co-authored-by: Bryce Mecum <petridish@gmail.com>
Co-authored-by: Bryce Mecum <petridish@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
--jsonoptions for output of info and search subcommands