Skip to content

Deprecate setShowIfEmpty() on Embedded Entity Lists #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PatrickePatate merged 2 commits into from
Jan 27, 2025
Merged

Deprecate setShowIfEmpty() on Embedded Entity Lists #570

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
839d856
Deprecate setShowIfEmpty() on Embedded Entity Lists
PatrickePatate Jan 27, 2025
307d838
Add deprecated message
PatrickePatate Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/Show/Fields/SharpShowEntityListField.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

use Code16\Sharp\Utils\Entities\SharpEntityManager;
use Code16\Sharp\Utils\Filters\Filter;
use Deprecated;

class SharpShowEntityListField extends SharpShowField
{
Expand Down Expand Up @@ -115,6 +116,15 @@ public function setLabel(string $label): self
return $this;
}

/**
* @deprecated Not used anymore, EEL are shown no matter what.
* @return SharpShowField
*/
public function setShowIfEmpty(bool $showIfEmpty = true): SharpShowField
{
return $this;
}

/**
* Create the properties array for the field, using parent::buildArray().
*/
Expand Down
Loading