Skip to content

Refine Reference Value#213

Draft
raphael-goetz wants to merge 3 commits intomainfrom
211-refine-reference-value
Draft

Refine Reference Value#213
raphael-goetz wants to merge 3 commits intomainfrom
211-refine-reference-value

Conversation

@raphael-goetz
Copy link
Member

Resolves: #211

// Ref Value points to a Result of a node, the int is the id of the node
int64 result = 2;
// Points to Value that is contained inside of a node
InputType input_type = 3;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicosammito does this case exist? I thought we only had references to flow inputs or return values of nodes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And also the references to the input of the flow itself. This is done by setting the nodeFunctionId to null. This is why we are making it optional on GraphQL

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry some misunderstanding. For example this is used inside for Each. The item is an input type defined within the Consumer DataType. Therefore we have 3 reference variants:

The flow input itself, a return type of a node and the input types of a parameter of type node

@Taucher2003

Co-authored-by: Niklas van Schrick <mc.taucher2003@gmail.com>
Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
// Ref Value points to a Result of a node, the int is the id of the node
int64 result = 2;
// Points to Value that is contained inside of a node
InputType input_type = 3;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry some misunderstanding. For example this is used inside for Each. The item is an input type defined within the Consumer DataType. Therefore we have 3 reference variants:

The flow input itself, a return type of a node and the input types of a parameter of type node

@Taucher2003

// Database Identifier of node
oneof target {
// Ref Value points to flow input
int64 flow_input = 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this pointing to the flowId?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it just be nothing, I thought we just always make this 0 but we can change it into something that represents empty

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep I would prefer the empty solution

Co-authored-by: Nico Sammito <nico@sammito.de>
Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add more Descriptive Reference Values

3 participants

Comments