Conversation
tiltingpenguin
requested changes
Mar 14, 2025
cmd/system.go
Outdated
| } | ||
|
|
||
| for _, itemName := range itemNames { | ||
| distro, err := Client.GetSystem(itemName, false, false) |
There was a problem hiding this comment.
This variable is still called distro
SchoolGuy
force-pushed
the
feature/export-json-yaml
branch
from
60df591 to
1c81390
Compare
tiltingpenguin
approved these changes
Mar 27, 2025
tiltingpenguin
left a comment
tiltingpenguin
left a comment
There was a problem hiding this comment.
Looks good to me now, you just forgot to change one variable name. If that is fixed we can merge
cmd/system.go
Outdated
| } | ||
|
|
||
| for _, itemName := range itemNames { | ||
| distro, err := Client.GetSystem(itemName, false, false) |
There was a problem hiding this comment.
This variable is still called distro
SchoolGuy
force-pushed
the
feature/export-json-yaml
branch
from
1c81390 to
88abf27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds functionality to allow the exporting of Cobbler objects as JSON or YAML.
Example usage:
This PR needs cobbler/cobblerclient#78 merged and the client version 0.5.8, which contains the merged PR.