Add binpack weigher for pods pipeline #461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Varsius
requested review from
PhilippMatthes,
SoWieMarkus,
auhlig,
juliusclausnitzer,
mblos and
umswmayj
as code owners
Varsius
force-pushed
the
pods-binpack-weigher
branch
from
548e360 to
eb87f46
Compare
PhilippMatthes
approved these changes
Jan 20, 2026
Member
PhilippMatthes
left a comment
PhilippMatthes
left a comment
There was a problem hiding this comment.
Just some minor comments
| return 0.0 | ||
| } | ||
|
|
||
| return math.Min(1.0, totalWeightedUtilization/totalWeight) |
Member
There was a problem hiding this comment.
Is it necessary to clamp the output weight? As tanh(-inf) = -1.0 and tanh(inf) = 1.0
Collaborator
Author
There was a problem hiding this comment.
I think so, since the highest value that should be possible is 1.0 which represents a perfect utilization of all resources and tanh(1.0)~=0.76. This prevents the case that a utilization calculation wrongly outputs a value greater than 1 which would result in a higher weight than tanh(1) and thus the node would get preferred over other nodes with perfect utilization. Does this make sense?
Member
There was a problem hiding this comment.
Right, thanks for the exaplanation.
Varsius
force-pushed
the
pods-binpack-weigher
branch
from
eb87f46 to
ae29e2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.