Fix unused workspace dependencies and lifetime syntax warnings #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The OctoBase project was generating numerous compiler warnings that were cluttering the build output and making it difficult to spot real issues:
Cargo.tomlSolution
This PR fixes all these warnings with minimal, surgical changes:
Fixed Workspace Dependencies
Removed incorrect
workspace = truekeys from workspace dependency definitions in the rootCargo.toml. These keys are only needed when consuming workspace dependencies, not when defining them.Fixed Lifetime Syntax Warnings
Added explicit
'_lifetime parameters to resolve "hiding a lifetime that's elided elsewhere" warnings across:AnsiGenericString<str>→AnsiGenericString<'_, str>BucketLockerreturn typesCleaned Up Unused Imports
Removed unused imports from
apps/keck/src/server/api/mod.rs:hash_map::EntryBroadcastTypebroadcastandmpsc::SenderUpdated Dependencies
Updated
wasm-bindgenfrom 0.2.87 to 0.2.88 to fix Rust compatibility issues.Impact
The remaining 6 warnings are intentionally left as they relate to Redis functionality that appears to be future implementation stubs based on the codebase structure.
Testing
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.