Open
Conversation
michalzurawski
requested review from
cierpuchaw,
jkmar,
kuba2 and
tmichalski-rtbh
as code owners
michalzurawski
force-pushed
the
add-log-for-created-resource
branch
from
1beb98f to
dc09aad
Compare
cloudwanbot
approved these changes
Jan 23, 2020
cloudwanbot
left a comment
cloudwanbot
left a comment
There was a problem hiding this comment.
STATUS: OK Please check the result of code analysis: http://10.135.224.43:9000/dashboard?id=gohan_add-log-for-created-resource
cierpuchaw
approved these changes
Jan 23, 2020
jkmar
reviewed
Jul 17, 2020
Contributor
jkmar
left a comment
jkmar
left a comment
There was a problem hiding this comment.
In current form I'm not sure if it is that useful, since it only works in very specific cases - creating resource by API. I would consider extending it to all created resources.
Contributor
tmichalski-rtbh
left a comment
tmichalski-rtbh
left a comment
There was a problem hiding this comment.
dummy comment to remove this PR from my review requests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.