generated from cloudoperators/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 1
feat(heureka): adds false positive actions and image version details page #1421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hodanoori
wants to merge
11
commits into
main
Choose a base branch
from
hoda-heureka-false-positive
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(heureka): adds image details page * chore(heureka): removes image details panel * feat(heureka): navigate from service panel to image details page * chore(heureka): adds changeset * chore(heureka): adjusts tests * chore(heureka): makes navigation checks generic * chore(heureka): makes navigation checks generic * fix(heureka): fixes prettier issue * feat(heureka): improves navigation and url definition * chore(heureka): adjusts test
…pattern for breadcrumb
🦋 Changeset detectedLatest commit: 6325218 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds false positive remediation to Heureka and introduces an image version details page. Users can mark vulnerabilities as false positive from the image details page, with success/error feedback via the message provider. The image version details page shows occurrences and vulnerabilities for a specific version. SHA256 identifiers are shortened to 7 characters in breadcrumbs and page titles for readabilityin image version details page.
Open Points
The remediated vulnerabilities tab currently does not display
severityinformation, and does not supportsearchorpagination. These features will be implemented once the corresponding API support becomes available.Changes Made
Added False Positive Remediation Action
FalsePositiveModalcomponent with required description fieldImplemented Message Provider for User Feedback
@cloudoperators/juno-messages-providerMessagesProviderwrapper in App.tsxMessagescomponent to root route for global message displayAdded Image Version Details Page
/services/$service/images/$image/versions/$versionfor image version detailsImageVersionDetailscomponent showing version-specific informationImageVersionOccurrencescomponent to display component instances for the versionImageVersionIssuesListcomponent to display vulnerabilities for the specific versionfetchImageVersionsAPI to load version-specific dataEnhanced Image Details Page
**Image Version Details Page: Improved SHA256 Display in Breadcrumb and Page Title **
getShortSha256()to extract first 7 characters after "sha256:"Related Issues
[Task](heureka): Add image version details page #1407
[Task](heureka): Perform false positive action to vulnerabilities in image details page #1408
[Task](heureka): Delete remediated status of vulnerabilities #1409
Screenshots (if applicable)
Testing Instructions
pnpm ipnpm TASKChecklist
PR Manifesto
Review the PR Manifesto for best practises.