-
Notifications
You must be signed in to change notification settings - Fork 842
Proposed changes for indexing. #3347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Proposed changes for indexing. #3347
Conversation
Adding mysql proposed indexing change.
Adding file for postgres.
Adding file for hsqldb
|
@rohit-armorikar Thank you! We will check, please sign CLA as required step to accept your PR, thanks in advance |
|
ok, you can and should run tests before the PR, see unit test failing because of index org.springframework.beans.BeanInstantiationException: Failed to instantiate [org.flywaydb.core.Flyway]: Factory method 'flyway' threw exception; nested exception is org.flywaydb.core.internal.command.DbMigrate$FlywayMigrateException: Migration V4_113__Add_Index_user_group_membership_groups.sql failed We run on MYSQL 5 and 8 and both fail. With docker and this help you can run tests yourself. |
Corrected the issues with queries as per MySql 8 version.
|
@strehle Thanks for your input, we have corrected the changes and pushed the updates. |
We have added few proposal for required indexing on tables.
Please review and let us know, which index out of the proposed one will help us for performance improvement.