Skip to content

Fix read file when ' ' in file name #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dany9966 merged 2 commits into from
Feb 17, 2026
Merged

Fix read file when ' ' in file name #389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
541268b
Fix read file when ' ' in file name
Cristi1324 Feb 16, 2026
22c0e0b
Update read file unit tests
Cristi1324 Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion coriolis/osmorphing/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,7 +491,7 @@ def _read_file_sudo(self, chroot_path):
if chroot_path.startswith("/") is False:
chroot_path = "/%s" % chroot_path
contents = self._exec_cmd_chroot(
'cat %s' % chroot_path)
'cat "%s"' % chroot_path)
return contents

def _read_grub_config(self, config):
Expand Down
2 changes: 1 addition & 1 deletion coriolis/providers/backup_writers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -911,7 +911,7 @@ def _setup_certificates(self, ssh):

def _read_remote_file_sudo(self, remote_path):
contents = utils.exec_ssh_cmd(
self._ssh, "sudo cat %s" % remote_path, get_pty=True)
self._ssh, 'sudo cat "%s"' % remote_path, get_pty=True)
return contents

def _init_writer(self, ssh, cert_paths):
Expand Down
4 changes: 2 additions & 2 deletions coriolis/tests/osmorphing/test_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -808,7 +808,7 @@ def test__read_file_sudo(self, mock_exec_cmd_chroot):

result = self.os_morphing_tools._read_file_sudo(chroot_path)

mock_exec_cmd_chroot.assert_called_once_with('cat %s' % chroot_path)
mock_exec_cmd_chroot.assert_called_once_with('cat "%s"' % chroot_path)
self.assertEqual(result, mock_exec_cmd_chroot.return_value)

@mock.patch.object(base.BaseLinuxOSMorphingTools, '_exec_cmd_chroot')
Expand All @@ -817,7 +817,7 @@ def test__read_file_sudo_no_leading_slash(self, mock_exec_cmd_chroot):

result = self.os_morphing_tools._read_file_sudo(chroot_path)

mock_exec_cmd_chroot.assert_called_once_with('cat /%s' % chroot_path)
mock_exec_cmd_chroot.assert_called_once_with('cat "/%s"' % chroot_path)
self.assertEqual(result, mock_exec_cmd_chroot.return_value)

@mock.patch.object(base.BaseLinuxOSMorphingTools, '_read_file_sudo')
Expand Down
3 changes: 2 additions & 1 deletion coriolis/tests/providers/test_backup_writers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1325,7 +1325,8 @@ def test__read_remote_file_sudo(self, mock_exec_ssh_cmd):
mock.sentinel.remote_path)

mock_exec_ssh_cmd.assert_called_once_with(
self._ssh, "sudo cat %s" % mock.sentinel.remote_path, get_pty=True)
self._ssh, 'sudo cat "%s"' % mock.sentinel.remote_path,
get_pty=True)
self.assertEqual(
result, mock_exec_ssh_cmd.return_value)

Expand Down