Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,9 @@ uuid = { version = "1.18.1", default-features = false }
# When updating the V8 crate, either update the version and hashes in that file,
# or ping phoebe @gefjon to do so.
v8 = "=145.0.0"
# This version is kept in sync with the version of ICU required by v8.
# When that changes, the `v8::icu::set_common_data_XX()` function is renamed.
deno_core_icudata = "0.77"

walkdir = "2.2.5"
wasmbin = "0.6"
Expand Down
1 change: 1 addition & 0 deletions crates/core/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ bytestring.workspace = true
chrono.workspace = true
crossbeam-channel.workspace = true
crossbeam-queue.workspace = true
deno_core_icudata.workspace = true
derive_more.workspace = true
dirs.workspace = true
enum-as-inner.workspace = true
Expand Down
7 changes: 7 additions & 0 deletions crates/core/src/host/v8/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,13 @@ impl V8RuntimeInner {
///
/// Should only be called once but it isn't unsound to call it more times.
fn init() -> Self {
// If the number in the name of this function is changed, update the version
// of the `deno_core_icudata` dep to match the number in the function name.
v8::icu::set_common_data_77(deno_core_icudata::ICU_DATA).ok();
// Set a default locale for functions like `toLocaleString()`.
// en-001 is "International English". <https://www.ctrl.blog/entry/en-001.html>
v8::icu::set_default_locale("en-001");

// We don't want idle tasks nor background worker tasks,
// as we intend to run on a single core.
// Per the docs, `new_single_threaded_default_platform` requires
Expand Down
Loading