Sort version output and show upgrade version #4250

aasoni · 2026-02-10T13:50:52Z

Description of Changes

The output of spacetime version list is sorted in alphabetical order, which is not the correct semver order.
This fixes the order printed, by sorting correctly.

Example before:

1.11.0
1.9.0
1.3.0
1.3.1
1.1.2
1.12.0 (current)
1.0.0

After:

1.12.0 (current)
1.11.0
1.9.0
1.3.1
1.3.0
1.1.2
1.0.0

Additionally, for discoverability when running spacetime version list, if the current version is older than the newest available version, the newest version is shown with a hint on how to upgrade to it:

1.12.0 (available - run `spacetime version upgrade`)
1.11.3 (current)
1.11.0
1.10.0
1.9.0
1.8.0
1.7.0

API and ABI breaking changes

Not an API or ABI breaking change

Expected complexity level and risk

1

Testing

Ran spacetime version list and spacetime version list --all with the new code and confirmed that the result was correctly sorted.
I additionally tested that if the latest available version was not installed that it would show with the upgrade hint command.

Copilot

Pull request overview

Fixes spacetime version list output ordering by sorting versions using semver rules and adds a discoverability hint showing the newest available version (with an upgrade command) when newer than the local/current version.

Changes:

Sorts version list using semver (descending), with a fallback bucket for non-semver strings.
Adds a GitHub “latest release” lookup and prints an “available” upgrade hint when appropriate.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
crates/update/src/cli/list.rs	Implements semver sorting and prints “available” newest version + upgrade hint.
crates/update/src/cli/install.rs	Adds helper to fetch latest release version from the GitHub releases API.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-10T14:07:26Z

crates/update/src/cli/list.rs

+        // Determine whether the latest version is newer than any installed version.
+        let newest_installed = sorted_versions.first().and_then(|v| semver::Version::parse(v).ok());
+
+        let show_latest = match (&latest, &newest_installed) {
+            (Some(lat), Some(cur)) if lat > cur => Some(lat.to_string()),


This compares the GitHub latest version against the newest installed version, but the PR description says the hint should appear when the current version is older than the newest available. If a user has a newer version installed but not selected as current, show_latest will be None and the upgrade hint won’t show even though current is older than latest. Consider parsing current (when present) to semver::Version and comparing latest > current_version (falling back to installed/newest only when current is missing).

Suggested change

// Determine whether the latest version is newer than any installed version.

let newest_installed = sorted_versions.first().and_then(|v| semver::Version::parse(v).ok());

let show_latest = match (&latest, &newest_installed) {

(Some(lat), Some(cur)) if lat > cur => Some(lat.to_string()),

// Determine whether the latest version is newer than the current version

// (if set), falling back to the newest installed version otherwise.

let newest_installed = sorted_versions

.first()

.and_then(|v| semver::Version::parse(v).ok());

let current_version = current

.as_ref()

.and_then(|v| semver::Version::parse(v).ok());

let show_latest = match (&latest, &current_version, &newest_installed) {

// Prefer comparing against the explicitly selected current version.

(Some(lat), Some(cur), _) if lat > cur => Some(lat.to_string()),

// If there is no valid current version, fall back to newest installed.

(Some(lat), None, Some(installed)) if lat > installed => Some(lat.to_string()),

The PR description is inaccurate in this case. The hint should only show if there is a newer version than any installed version. This is because all installed versions are listed in spacetime version list and therefore discoverable. The main point of showing that there is a new version is that it is otherwise unknown to the user that a new version is available unless they run spacetime upgrade.

Copilot · 2026-02-10T14:07:26Z

crates/update/src/cli/list.rs

+        // Sort versions using semver ordering. Versions that fail to parse are
+        // placed at the end in alphabetical order.
+        let mut parsed: Vec<(semver::Version, String)> = Vec::new();
+        let mut unparsed: Vec<String> = Vec::new();
        for ver in versions {
-            print!("{ver}");
-            if Some(&ver) == current.as_ref() {
-                print!(" (current)");
+            match semver::Version::parse(&ver) {
+                Ok(sv) => parsed.push((sv, ver)),
+                Err(_) => unparsed.push(ver),
            }
-            println!();
        }
+        parsed.sort_by(|(a, _), (b, _)| b.cmp(a));
+
+        let sorted_versions: Vec<String> = parsed.into_iter().map(|(_, s)| s).chain(unparsed).collect();


The comment says unparseable versions are placed at the end in alphabetical order, but unparsed is never sorted—it's appended in the original iteration order. Either sort unparsed before chaining (e.g., unparsed.sort()), or adjust the comment to match the actual behavior.

Updated the comment

bfops · 2026-02-10T18:50:20Z

crates/update/src/cli/install.rs

+        .json()
+        .await?;
+    release.version().context("Could not parse latest version number")
+}


nit: instead of adding this function, I think we could instead factor this out of download_and_install instead:

pub(super) async fn fetch_release( client: &reqwest::Client, version: Option<semver::Version>, ) -> anyhow::Result<Release> { let releases_url = releases_url(); let url = match &version { Some(version) => format!("{releases_url}/tags/v{version}"), None => [&*releases_url, "/latest"].concat(), }; let release = client .get(url) .send() .await? .error_for_status() .map_err(|e| { if e.status() == Some(reqwest::StatusCode::NOT_FOUND) { if let Some(version) = &version { return anyhow::anyhow!(e).context(format!("No release found for version {version}")); } } anyhow::anyhow!(e).context("Could not fetch release info") })? .json() .await?; Ok(release) }

bfops · 2026-02-10T18:52:55Z

crates/update/src/cli/list.rs

        };
+
+        // Sort versions using semver ordering. Versions that fail to parse are
+        // placed at the end in their original listed.


maybe a dumb question, but why would a version fail to parse?

bfops · 2026-02-10T18:58:30Z

crates/update/src/cli/list.rs

+        let sorted_versions: Vec<String> = parsed.into_iter().map(|(_, s)| s).chain(unparsed).collect();
+
+        // Check for a newer version available on GitHub.
+        let latest = if !self.all {


why only in the !self.all case? I would expect this hint to happen regardless of whether we run with --all?

ah because it will be self-evident in that case?

bfops · 2026-02-10T18:59:01Z

crates/update/src/cli/list.rs

+        let newest_installed = sorted_versions.first().and_then(|v| semver::Version::parse(v).ok());
+
+        let show_latest = match (&latest, &newest_installed) {
+            (Some(lat), Some(cur)) if lat > cur => Some(lat.to_string()),


I think if the current version doesn't parse, we should probably the hint to upgrade them to the latest version.

bfops · 2026-02-10T19:01:34Z

crates/update/src/cli/list.rs

+                if let Some(ref new_ver) = show_latest {
+                    println!("{} {}", new_ver, "(available - run `spacetime version upgrade`)");
+                }
+            }


this does seem weird if the current version isn't the latest

how about instead of trying to show the latest version "inline", we just print a message at the top that says something like "version xyz is available, run spacetime version upgrade to update!" and then print the list as normal?

aasoni added 4 commits February 10, 2026 13:30

Sort version output and show upgrade version

816f924

simplify comment

1ee294d

Print available version first if current is not set

671fddf

Fix getting latest installed

c7e4a0f

aasoni requested review from bfops, coolreader18 and Copilot February 10, 2026 14:06

Copilot AI reviewed Feb 10, 2026

View reviewed changes

Update comment

f8c6f6a

bfops linked an issue Feb 10, 2026 that may be closed by this pull request

CLI - Let users know if there's a new version available #1822

Open

4 tasks

Format

b973d2c

bfops reviewed Feb 10, 2026

View reviewed changes

bfops removed a link to an issue Feb 10, 2026

CLI - Let users know if there's a new version available #1822

Open

4 tasks

bfops mentioned this pull request Feb 10, 2026

CLI - Let users know if there's a new version available #1822

Open

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sort version output and show upgrade version #4250

Sort version output and show upgrade version #4250

Uh oh!

aasoni commented Feb 10, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 10, 2026

Uh oh!

aasoni Feb 10, 2026

Uh oh!

Copilot AI Feb 10, 2026

Uh oh!

aasoni Feb 10, 2026

Uh oh!

bfops Feb 10, 2026 •

edited

Loading

Uh oh!

bfops Feb 10, 2026

Uh oh!

bfops Feb 10, 2026

Uh oh!

bfops Feb 10, 2026

Uh oh!

bfops Feb 10, 2026

Uh oh!

bfops Feb 10, 2026

Uh oh!

bfops Feb 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Sort version output and show upgrade version #4250

Are you sure you want to change the base?

Sort version output and show upgrade version #4250

Uh oh!

Conversation

aasoni commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of Changes

API and ABI breaking changes

Expected complexity level and risk

Testing

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bfops Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

aasoni commented Feb 10, 2026 •

edited

Loading

bfops Feb 10, 2026 •

edited

Loading