Add warning prompt for 1.0 -> 2.0 module upgrade path #4247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-spacetime
requested review from
bfops,
cloutiertyler and
jdetter
as code owners
joshua-spacetime
force-pushed
the
joshua/cli-warning
branch
from
25aa0dc to
983ced0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Adds a warning prompt for 1.0 -> 2.0 module upgrade path.
API and ABI breaking changes
None
Expected complexity level and risk
1
Testing
This patch checks a wasm module binary compiled with pre-2.0 bindings into source control. A smoketest was added that first publishes the the pre-compiled module and then publishes a new module using the 2.0 bindings in its place.