Block procedures from requesting private ip ranges #4243
+726
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfops
approved these changes
Feb 10, 2026
Kasama
requested changes
Feb 10, 2026
Kasama
approved these changes
Feb 10, 2026
Kasama
requested changes
Feb 10, 2026
Contributor
Kasama
left a comment
Kasama
left a comment
There was a problem hiding this comment.
Oops. Accidentally approved instead of requesting changes.
Again, we probably don't want to test this many IPs in the final test, but I've commented with them for now so we can be pretty sure those ranges are covered
joshua-spacetime
force-pushed
the
joshua/block-internal-ips
branch
from
e5a1772 to
7acdc5a
Compare
Kasama
approved these changes
Feb 10, 2026
Contributor
Kasama
left a comment
Kasama
left a comment
There was a problem hiding this comment.
All ranges look to be covered!
Contributor
|
just one nit. As these ip checks are a big blob of numbers and checks kinda unrelated to the rest of the file. Would it make sense to move those checks onto a separate module instead? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Blocks procedures from requesting private ip ranges after dns resolution.
API and ABI breaking changes
None
Expected complexity level and risk
Testing