Upgrade dependencies (React, Typescript, Eslint, get rid of Tslint), mark componentWillReceiveProps as Unsafe#95
Open
manvydasu wants to merge 5 commits intoclauderic:masterfrom
Conversation
…d in tsconfig.json, fix invalid props being passed to DOM
manvydasu
force-pushed
the
feat/upgrade-dependencies
branch
from
4e6cdd6 to
e4f249a
Compare
mshwery
approved these changes
Jul 29, 2021
package.json
Outdated
| "react": "^17.0.1", | ||
| "react-addons-test-utils": "^15.6.2", | ||
| "react-dom": "^17.0.1", | ||
| "react-test-renderer": "^17.0.1", |
package.json
Outdated
| "react-test-renderer": "^15.4.2", | ||
| "prettier": "^2.2.1", | ||
| "react": "^17.0.1", | ||
| "react-addons-test-utils": "^15.6.2", |
package.json
Outdated
| }, | ||
| "peerDependencies": { | ||
| "react": "15.x || 16.x" | ||
| "react": "15.x || 16.x || 17.x" |
Author
There was a problem hiding this comment.
You're right, I forgot that UNSAFEs were added only with 16.3.. Thanks for review, hopefully @clauderic can look into it, since a lot of people have to spend time forking the repo.
Domush
suggested changes
Nov 20, 2021
Author
What do you mean by a 'lot of unnecessary Dev dependencies'? This project is already using shopify's eslint configuration. I just upgraded it to newer version. and .eslintrc file is not user specific. That's rules for the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Next step would be to replace deprecated UNSAFE_componentWillReceiveProps with something else (#85).