Create one sync storage post per room#3
Merged
chriszarate merged 2 commits intoadd/collaboration-functionalityfrom Feb 19, 2026
Merged
Create one sync storage post per room#3chriszarate merged 2 commits intoadd/collaboration-functionalityfrom
chriszarate merged 2 commits intoadd/collaboration-functionalityfrom
Conversation
westonruter
reviewed
Feb 19, 2026
There was a problem hiding this comment.
This could become a const now instead.
| * @var array<string, int> | ||
| */ | ||
| private static ?int $storage_post_id = null; | ||
| private static array $storage_post_ids = array(); |
There was a problem hiding this comment.
In practice, will there ever be more than one ID in this array for a given request?
Owner
Author
There was a problem hiding this comment.
Owner
Author
|
I've given this some good testing, it's straightforward, and the feedback suggests that is an impactful improvement. Therefore I'm going to merge it into the base branch. Feel free to leave additional feedback on that PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Create one sync storage post per room for storing sync updates instead of one singleton post.
Trac ticket: https://core.trac.wordpress.org/ticket/64622
In the base PR, @mindcrtl noted:
This implements that suggestion, creating one
wp_sync_storagepost per room and storing updates in post meta against each post.