(#1264) Update pages to use xrefs instead of direct links #1266
+17
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I will take this for a spin and add a review tomorrow. |
st3phhays
requested changes
Jan 28, 2026
Comment on lines
+85
to
91
| * `virusCheckMinimumPositives` = **'4'** - Minimum number of scan result positives before flagging a binary as a possible virus. Used when virusScannerType is VirusTotal. Licensed editions only. See <Xref title="Virus Check" value="virus-check" />. | ||
| * `virusScannerType` = **'VirusTotal'** - Virus Scanner Type (Generic or VirusTotal). Defaults to VirusTotal for Pro. Licensed editions only. See <Xref title="Virus Check" value="virus-check" />. | ||
| * `genericVirusScannerPath` = **' '** - The full path to the command line virus scanner executable. Used when virusScannerType is Generic. Licensed editions only. See <Xref title="Virus Check" value="virus-check" />. | ||
| * `genericVirusScannerArgs` = **'`[[File]]`'** - The arguments to pass to the generic virus scanner. Use `[[File]]` for the file path placeholder. Used when virusScannerType is Generic. Licensed editions only. See <Xref title="Virus Check" value="virus-check" />. | ||
| * `genericVirusScannerValidExitCodes` = **'0'** - The exit codes for the generic virus scanner when a file is not flagged. Separate with comma, defaults to 0. Used when virusScannerType is Generic. Licensed editions only. See <Xref title="Virus Check" value="virus-check" />. | ||
| * `genericVirusScannerTimeoutInSeconds` = **'120'** - Generic Virus Scanner Timeout In Seconds - The number of seconds to allow the virus scanner to run before timing out. Used when virusScannerType is Generic. Defaults to '120'. Licensed editions v2.1.0+ only. See <Xref title="Virus Check" value="virus-check" />. | ||
|
|
Member
There was a problem hiding this comment.
Coming from an accessibility side, having so many links that all have the same text isn't great. Since these are all the same link essentially, what if we put one sentence above the list that points to it. Something like Learn more about <Xref title="Virus Checking configuration" value="virus-check" /> on our detailed docs.. We could then remove these repetitive links. on each list item.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Update the configuration page to use xrefs instead of direct links.
Motivation and Context
See #1264
Testing
Change Types Made
Change Checklist
Related Issue