Fix: Respect --log-level flag for SBOM deduplication logs#1901
Open
npneeraj wants to merge 1 commit intochainguard-dev:mainfrom
Open
Fix: Respect --log-level flag for SBOM deduplication logs#1901npneeraj wants to merge 1 commit intochainguard-dev:mainfrom
npneeraj wants to merge 1 commit intochainguard-dev:mainfrom
Conversation
Change deduplication log from Info to Debug level Signed-off-by: Neeraj Panwar <49247372+npneeraj@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #1899
When using the
--log-level=errorflag, INFO level logs were still being printed, specifically the SBOM package deduplication message:This occurs because the deduplication log statement in
spdx.gowas using.Info()level, which doesn't get filtered out when the log level is set to error.Solution
Changed the log level from
InfotoDebugfor the duplicate package deduplication message inpkg/sbom/generator/spdx/spdx.go(line 161).This change:
--log-levelflag properlyworld.go)Type of Change
Checklist
Additional Context
This is a one-line change that only affects logging verbosity, not functionality.
Package deduplication continues to work exactly as before; only the visibility of the log message changes based on the configured log level.