Open
Conversation
Adds a test for syntactical, quality and macro filing failures (i.e. edits are triggered after uploading the fixtures). I chose not to duplicate the fixtures and create one for every year (a la Filing.spec.js) because it would result in a 30+ minute test that just tests the same functionality over and over again. Instead I just made a few fixtures for 2025 and labeled them accordingly. See https://github.local/HMDA-Operations/hmda-devops/issues/5274
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tests for syntactical, quality and macro filing failures (i.e. edits are triggered after uploading the fixtures).
It'd be easy to duplicate these fixtures and create one for every year (a la
Filing.spec.js) but IMHO it wouldn't add any value because it would just test the same thing over and over again and result in a 30+ minute run time. Instead I just made a few fixtures for 2025 and labeled them accordingly.See #5274
Changes
Notes
beforehooks are copied fromFiling.spec.js.Testing
Filing-failures.spec.jsfile and the tests should pass.