This repository was archived by the owner on Jan 8, 2020. It is now read-only.
Open
Conversation
…a hyphen the change makes the code ignore a hyphen as the first digit to get around this
…should be done by toInt. This produces fewer lines of code and seems more logically consistant, rather than breaking out one case for special treatment
…t with no entry in field
… whether a blank field should be even or odd
…r, missing the full interpolator and prefix. Also, I believe all of the other tests are covered by the final two test which cover caluclateAddressRange, I was not sure if there were still value in the other tests so I am leaving them
…n geometry (0,0) regardless of line parameters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tests to the interpolator, also moves some functionality into searchUtils to reduce lines of code and increase consistency.
Currently a work in progress due to a full line test in interpolateSpec failing due to the geometry likely being improperly formatted in the test. The interpolator always returns the point (0,0) regardless of the input geometry.