Skip to content

Conversation

@larsewi
Copy link
Contributor

@larsewi larsewi commented Aug 11, 2025

This commit broke docs because it depends on
cfengine/core#5850. Once the dependency is
merged, it should be safe to reapply this commit.

This reverts commit 3bc6348.

Ticket: CFE-4562
Signed-off-by: Lars Erik Wik lars.erik.wik@northern.tech

…/objects"

This commit broke docs because it depends on
cfengine/core#5850. Once the dependency is
merged, it should be safe to reapply this commit.

This reverts commit 3bc6348.

Ticket: CFE-4562
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
@larsewi
Copy link
Contributor Author

larsewi commented Aug 11, 2025

Please wait with merging this until dependency (cfengine/core#5850) is merged

@larsewi
Copy link
Contributor Author

larsewi commented Aug 19, 2025

@cf-bottom Jenkins please :)

@cf-bottom
Copy link

@larsewi
Copy link
Contributor Author

larsewi commented Aug 19, 2025

@cf-bottom Jenkins please :)

@cf-bottom
Copy link

@larsewi
Copy link
Contributor Author

larsewi commented Aug 19, 2025

^ Looks like the arguments did not automatically update. Is this cached somehow? 🤔

@larsewi larsewi requested a review from nickanderson August 19, 2025 14:16
@larsewi larsewi marked this pull request as ready for review August 19, 2025 14:16
@larsewi
Copy link
Contributor Author

larsewi commented Aug 25, 2025

Ping @nickanderson

@nickanderson
Copy link
Member

^ Looks like the arguments did not automatically update. Is this cached somehow? 🤔

I believe that comes from the syntax-description. So maybe the binary version generating the syntax didnt have your patch to evalfunction.c.

cf-promises --syntax-description=json | jq '.functions.classfilterdata'
{
  "cached": false,
  "category": "io",
  "collecting": true,
  "parameters": [
    {
      "description": "CFEngine variable identifier or inline JSON",
      "range": ".*",
      "type": "string"
    },
    {
      "description": "Specify type of data structure",
      "range": "array_of_arrays,array_of_objects,auto",
      "type": "option"
    },
    {
      "description": "Key or index of class expressions",
      "range": ".*",
      "type": "string"
    }
  ],
  "returnType": "data",
  "status": "normal",
  "variadic": false
}

@nickanderson nickanderson merged commit 3abfae6 into cfengine:master Aug 25, 2025
2 checks passed
@larsewi
Copy link
Contributor Author

larsewi commented Aug 26, 2025

I believe that comes from the syntax-description. So maybe the binary version generating the syntax didnt have your patch to evalfunction.c.

Probably! At least it looks correct on the website now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants