-
Notifications
You must be signed in to change notification settings - Fork 421
docs: add guide for aws-kms #2388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @jcstein, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new, detailed guide for integrating the 'op-alt-da' data availability server with AWS Key Management Service (KMS). The guide provides step-by-step instructions for both local development using Localstack and production deployment, ensuring secure key management for Celestia keys. To accommodate this new content, the existing 'op-alt-da' documentation has been reorganized, and various project dependencies have been updated to their latest versions. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
🚀 Preview Deployment Your preview is ready: https://celestiaorg.github.io/docs-preview/pr-2388/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new guide for using op-alt-da with AWS KMS, which is a valuable addition to the documentation. The changes also include restructuring the existing op-alt-da documentation into an introduction page. My review focuses on the new guide, with suggestions to improve clarity, consistency, and user-friendliness. Specifically, I've recommended using HTTPS for git cloning, fixing some markdown formatting, and ensuring commands and placeholders are consistent throughout the guide.
tuxcanfly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK.
- Change git clone URL from SSH to HTTPS - Remove indentation from explanatory note - Add AWS_DEFAULT_REGION to da-server command - Update Celenium link text for clarity - Make placeholder consistent (YOUR_EXPORTED_PRIVATE_KEY_HEX) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Overview