Fix empty message in newer Sublime Text 4 versions #26
Open
dsego wants to merge 1 commit intocbumgard:masterfrom
Open
Fix empty message in newer Sublime Text 4 versions #26dsego wants to merge 1 commit intocbumgard:masterfrom
dsego wants to merge 1 commit intocbumgard:masterfrom
Conversation
The new_file.insert method was misusing the `edit` parameter. Instead we can invoke a command to append text in the newly created window. Context: The edit parameter is not for new_file but for self.view. Build 4158 https://www.sublimetext.com/dev - API: Fixed crash when an edit token is passed to the wrong view (sublimehq/sublime_text#6177) API Docs: https://www.sublimetext.com/docs/api_reference.html#sublime.Edit > Edit objects are passed to TextCommands, and can not be created by the user. Using an invalid Edit object, or an Edit object from a different View, will cause the functions that require them to fail.
dsego
changed the title
dsego
changed the title
|
This fix works for me using the latest GitCommitMsg in Sublime Text Build 4166. Thanks @dsego ! |
|
helpful, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
new_file.insertmethod was misusing theeditparameter. Instead we can invoke a command to append text in the newly created window.Context:
The edit parameter is not for new_file but for self.view.
Build 4158
https://www.sublimetext.com/dev
API Docs:
https://www.sublimetext.com/docs/api_reference.html#sublime.Edit
My report on Sublime Text bug tracker:
sublimehq/sublime_text#6177
Closes issue #25