use column-major order when constructing GLSL matrices#33
Open
reims wants to merge 1 commit intocbaggers:masterfrom
Open
use column-major order when constructing GLSL matrices#33reims wants to merge 1 commit intocbaggers:masterfrom
reims wants to merge 1 commit intocbaggers:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some functions in the vari part of rtg-math use row-major order when constructing matrices. These matrices then cannot be used with normal GLSL operations because GLSL uses column-major order.
This pull request changes this for most of the functions that construct matrices.
I did not check all functions for this issue. Missing are (in m3 and in m4)
rotation-from-euleradjointfrom-directionpoint-atlook-at