Open
Conversation
Owner
|
I believe that actual type list can be changed in future. So I will be a little bit painful to track these changes. And that's why I've decided to not add such check. |
Contributor
Author
|
Alright, that makes sense. |
Owner
|
Actually So we need leave type = 'content' if type == 'download' else type |
Contributor
Author
|
Not sure if i follow; are you saying the API used to have a /download endpoints that was renamed /content? If so, yeah, that conversion might be helpful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The final allowed type is 'content'.
What do you think about raising a ValueError if
typeis not in a list of valid options, similar to the implementation ofallowed_extensionsinget_document_content()?