feat!: support FlorisBoard >=0.5.0

[cravl-dev]

🎉 Updated to Snygg v2 for FlorisBoard 0.5.0! 🎉
Based on the diffs from the official theme updates:

• extension.json
• Theme JSONs

My brief test drive hasn't revealed any glaring issues but there may be some dialog or popup that I haven't seen. The one weird thing is the Android autofill service suggestions, which always have a white background that I can't seem to change. The default themes have the same problem though, so I'll try to open an issue upstream and hopefully we'll get a new Snygg target for theming those.

I also whiskers-ified extension.json—this isn't strictly necessary for how the themes are configured currently, but it makes more sense with my accent-themes branch that generates separate themes for each accent color (with pre-defined secondaries that I thought went well, because generating all 182 permutations is a bit much. 😅). Feel free to take or leave whatever you like in that respect.

Fixes #21

[sgoudham]

Thanks for the PR, I've skimmed the PR and can't comment on the theme yet but I'd rather not convert the extension.json into a whiskers template at the moment.

I'd appreciate if you could revert changes to extension.json, justfile and CHANGELOG.md. (The CHANGELOG is automatically updated)

[cravl-dev]

Done! Let me know if there's anything else, happy to help. I left it as version 2.0.0 as per semver for breaking changes, but I can change it if there's something else you'd rather do.

[cravl-dev]

I tried to remove all the definitions that didn't used to be necessary, but it seems like some defaults were removed. It seems this is now more or less the minimum of what must be specified. (EDIT: found the defaults here.)

I also tried to revert to using key code names, but it's not supported anymore as far as I can tell. The in-app theme editor forces use of an integer as well. I put the key code names in comments for clarity.

Aside from tweaking the popup color and the padding on the key hint, nothing else has changed.
EDIT: I also found and fixed some smartbar-related spacing issues.

[cravl-dev]

I think the code side of things is done, unless you have anything more. Now it's just a matter of reviewing the theme visually. I'm sure it's not 1 to 1 identical as it was, but subjectively I think it looks good and not noticeably different.

[sgoudham]

I tried to remove all the definitions that didn't used to be necessary, but it seems like some defaults were removed. It seems this is now more or less the minimum of what must be specified.

This is quite unfortunate.

I think the code side of things is done, unless you have anything more. Now it's just a matter of reviewing the theme visually. I'm sure it's not 1 to 1 identical as it was, but subjectively I think it looks good and not noticeably different.

I'll give it a proper review after trying it out, thanks for your work so far 👍

[seleniy]

The florisboard.tera file is missing a comma on line 152, which causes jq to generate an error jq: parse error: Expected separator between values at line 142, column 33 when just zip is run.

[cravl-dev]

The florisboard.tera file is missing a comma on line 152, which causes jq to generate an error jq: parse error: Expected separator between values at line 142, column 33 when just zip is run.

@seleniy Fixed, thanks!

[sgoudham]

Sorry for the huge wait on reviewing this PR, totally forgot about it.

I see that v0.5.0-rc01 has been released which I assume means that the official release is close by so would be good to get this merged.

Can you confirm that the highlights look okay on the latest pre-release linked above? @cravl-dev

[sgoudham]

I had a chance to test this on the new release candidate and it works well!

I'm not happy about having to define the font size, shape, etc but the theme still looks how it was before so happy with that.

Thank you so much for this work and sorry for the wait on the merge!

[cravl-dev]

My pleasure, thank you!