Add support to handle additional OCI tags from user input#553
Add support to handle additional OCI tags from user input#553phenixblue wants to merge 12 commits intocarvel-dev:developfrom
Conversation
Signed-off-by: Joe Searcy <joe@twr.io>
Signed-off-by: Joe Searcy <joe@twr.io>
Signed-off-by: Joe Searcy <joe@twr.io>
Signed-off-by: Joe Searcy <joe@twr.io>
Signed-off-by: Joe Searcy <joe@twr.io>
Signed-off-by: Joe Searcy <joe@twr.io>
Signed-off-by: Joe Searcy <joe@twr.io>
Signed-off-by: Joe Searcy <joe@twr.io>
joaopapereira
left a comment
There was a problem hiding this comment.
Some nitpicks and a question.
Do you think it would also make sense to add 1 end 2 end test to ensure all is good?
Signed-off-by: Joe Searcy <joe@twr.io>
Signed-off-by: Joe Searcy <joe@twr.io>
Signed-off-by: Joe Searcy <joe@twr.io>
Signed-off-by: Joe Searcy <joe@twr.io>
|
I'm not familiar with the end-to-end tests. Can you point me at an example or describe what that might look like? |
Maybe we can use https://github.com/carvel-dev/imgpkg/blob/develop/test/e2e/push_test.go as a base. Just making sure that the correct tags are added to the file and also in the registry (https://github.com/carvel-dev/imgpkg/blob/develop/test/e2e/copy_from_lockfiles_test.go#L226), this last example is on how can we check that multiple tags are present in the registry but the rest of the test is a copy test which we do not want to do. |
|
Ok, I'll take a look and give it a shot |
|
I've not been able to look at this much in the past few months due to a job change, but will be getting back to it soon |
These changes add the ability to specify additional OCI tags to be pushed when using
imgpkg.It adds the
--additional-tagsflag toimgpkg pushcommand and allows the user to specify a comma separated list of additional tags, or the flag can be reused multiple times. This flag functions for both images and bundles.Comma Separated List
Multiple flags
Fixes #355