-
Notifications
You must be signed in to change notification settings - Fork 12
Add HTML prerendering for FileDef entries during indexing #3918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lukemelia
wants to merge
9
commits into
main
Choose a base branch
from
cs-10124-capture-filedef-prerendered-formats-during-indexing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+757
−3
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1d3f8f4
Add HTML prerendering for FileDef entries during indexing
lukemelia c1737ca
Fix lint errors, prettier formatting, and type issues
lukemelia c83b0d6
Remove redundant consumeClearCacheForRender call in file render phase
lukemelia b435211
Skip file HTML render for modules and card instances during indexing
lukemelia e950d9c
Revert "Skip file HTML render for modules and card instances during i…
lukemelia 221a30e
Increase realm-server test timeout to 180s for file render overhead
lukemelia ff19e3d
Render only isolated HTML for file entries to fix CI timeouts
lukemelia c76a69a
Fix CI timeouts: add manager proxy route, fix expectedId, skip module…
lukemelia 1c6ddf5
Restore realm-server test timeout to 60s
lukemelia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fileRender path instantiates the card via
cardApi.createFromSerializedwithout passing a store, which means it falls back toFallbackCardStore(seepackages/base/card-api.gts) that fetches related resources with the globalfetchand no auth context. If a FileDef template touches linked/computed fields that need realm auth, those loads will 401 or be skipped, so prerendered HTML can be incomplete or incorrect. The normal render path wires instances throughthis.store.add/store.loaded()to ensure authenticated loading; this new branch should do the same or pass the render store intocreateFromSerialized.Useful? React with 👍 / 👎.