Update custom domain publishing approach #3917
Conversation
Preview deployments |
ugh what is happening
backspace
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4be20c6cc3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (publishedURL.host.toLowerCase() !== overrideDomain.toLowerCase()) { | ||
| return { applied: false, publishedRealmURL }; |
There was a problem hiding this comment.
This check only applies an override when the requested publishedRealmURL host already equals the override domain. In practice the publish modal still builds URLs using the base Boxel site domain (e.g. *.boxel.site), so any override configured for the source realm is skipped and the realm is published to the base domain instead of the intended custom domain. Unless clients are already sending the custom domain in the publish request, the override never takes effect, which contradicts the UI’s “This site will publish to …” display and the override mapping.
Useful? React with 👍 / 👎.
More requirements have emerged so I’m adapting the implementation of custom domain publishing, which is a workaround until we have full support for dynamic creation of CNAMES and the like.
PUBLISHED_REALM_DOMAIN_OVERRIDESis an environment variable that lets us add to the hardcoded mapping without requiring a full deployment.PUBLISHED_REALM_DOMAIN_OVERRIDESthrough from the realm server’sindex.html-serving function.