Skip to content

Conversation

@clchiou
Copy link
Contributor

@clchiou clchiou commented Jan 25, 2026

A previous commit (1423761) fixed this bug in double-far pointer creation; this commit fixes it in single far pointer creation.

A previous commit (1423761) fixed this
bug in double-far pointer creation; this commit fixes it in single far
pointer creation.
@clchiou
Copy link
Contributor Author

clchiou commented Jan 25, 2026

Hi @dwrensha, it appears to me that the kind function should be applied to src, not srcTarget. The C++ and Rust library code does just that, and there was a bug fix in the double-far code path.

@clchiou
Copy link
Contributor Author

clchiou commented Jan 28, 2026

ping?

@clchiou
Copy link
Contributor Author

clchiou commented Jan 31, 2026

Hi @dwrensha , I believe this PR fixes a genuine bug. Would you mind taking a look?

@dwrensha dwrensha merged commit 1a0ac9d into capnproto:master Feb 1, 2026
1 check passed
@dwrensha
Copy link
Member

dwrensha commented Feb 1, 2026

Thanks!

@clchiou clchiou deleted the transfer-pointer-landing-pad branch February 1, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants