Merged
Conversation
c83fb61 to
fddc8eb
Compare
yjacolin
previously requested changes
Jan 29, 2026
79eddd5 to
4ea97a4
Compare
vrenaville
approved these changes
Jan 30, 2026
4ea97a4 to
9c6c201
Compare
florentx
reviewed
Feb 2, 2026
Makefile
Outdated
| @echo Postgis versions $2 | ||
| @echo Debian release $3 | ||
| docker build --pull --no-cache --build-arg BASE_TAG=${1} --build-arg POSTGIS_VERSIONS=${2} --build-arg DEBIAN_RELEASE=${3} -t camptocamp/postgres:${1}-postgis-$(subst $(space),-,${2}) . | ||
| docker build --pull --no-cache --build-arg BASE_TAG=${1} --build-arg POSTGIS_VERSIONS=${2} --build-arg DEBIAN_RELEASE=${3} --build-arg PGVECTOR_VERSION=${PGVECTOR_VERSION} -t camptocamp/postgres:${1}-postgis-$(subst $(space),-,${2}) . |
There was a problem hiding this comment.
For some reason, syntax seems to be:
Suggested change
| docker build --pull --no-cache --build-arg BASE_TAG=${1} --build-arg POSTGIS_VERSIONS=${2} --build-arg DEBIAN_RELEASE=${3} --build-arg PGVECTOR_VERSION=${PGVECTOR_VERSION} -t camptocamp/postgres:${1}-postgis-$(subst $(space),-,${2}) . | |
| docker build --pull --no-cache --build-arg BASE_TAG=${1} --build-arg POSTGIS_VERSIONS=${2} --build-arg DEBIAN_RELEASE=${3} --build-arg PGVECTOR_VERSION=$(PGVECTOR_VERSION) -t camptocamp/postgres:${1}-postgis-$(subst $(space),-,${2}) . |
Member
There was a problem hiding this comment.
Hello, thanks for the suggestion. The ${} syntax is used to fetch argument to the build-image function/macro. So if you would like to use a global variable you need to use this syntax : $()
I also push another fix in 94f6a19 to be able to use the PGVECTOR_VERSION in the Dockerfile.
ARG before FROM can only be used in the FROM line, if you need to use a variable in the body (other Dockerfile statement) you need to declare variable with ARG just after the FROM.
Member
|
@gurneyalex Can you add the following commits to your feature branch please : |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.