Skip to content

[ADD] pgvector extension#22

Merged
Vampouille merged 3 commits intocamptocamp:masterfrom
gurneyalex:add-pgvector
Feb 2, 2026
Merged

[ADD] pgvector extension#22
Vampouille merged 3 commits intocamptocamp:masterfrom
gurneyalex:add-pgvector

Conversation

@gurneyalex
Copy link
Member

No description provided.

@gurneyalex gurneyalex force-pushed the add-pgvector branch 2 times, most recently from 79eddd5 to 4ea97a4 Compare January 29, 2026 09:46
@gurneyalex gurneyalex requested a review from yjacolin January 30, 2026 17:05
Makefile Outdated
@echo Postgis versions $2
@echo Debian release $3
docker build --pull --no-cache --build-arg BASE_TAG=${1} --build-arg POSTGIS_VERSIONS=${2} --build-arg DEBIAN_RELEASE=${3} -t camptocamp/postgres:${1}-postgis-$(subst $(space),-,${2}) .
docker build --pull --no-cache --build-arg BASE_TAG=${1} --build-arg POSTGIS_VERSIONS=${2} --build-arg DEBIAN_RELEASE=${3} --build-arg PGVECTOR_VERSION=${PGVECTOR_VERSION} -t camptocamp/postgres:${1}-postgis-$(subst $(space),-,${2}) .
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, syntax seems to be:

Suggested change
docker build --pull --no-cache --build-arg BASE_TAG=${1} --build-arg POSTGIS_VERSIONS=${2} --build-arg DEBIAN_RELEASE=${3} --build-arg PGVECTOR_VERSION=${PGVECTOR_VERSION} -t camptocamp/postgres:${1}-postgis-$(subst $(space),-,${2}) .
docker build --pull --no-cache --build-arg BASE_TAG=${1} --build-arg POSTGIS_VERSIONS=${2} --build-arg DEBIAN_RELEASE=${3} --build-arg PGVECTOR_VERSION=$(PGVECTOR_VERSION) -t camptocamp/postgres:${1}-postgis-$(subst $(space),-,${2}) .

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thanks for the suggestion. The ${} syntax is used to fetch argument to the build-image function/macro. So if you would like to use a global variable you need to use this syntax : $()
I also push another fix in 94f6a19 to be able to use the PGVECTOR_VERSION in the Dockerfile.
ARG before FROM can only be used in the FROM line, if you need to use a variable in the body (other Dockerfile statement) you need to declare variable with ARG just after the FROM.

@Vampouille
Copy link
Member

@gurneyalex Can you add the following commits to your feature branch please :

@Vampouille Vampouille merged commit 35a7f8f into camptocamp:master Feb 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants