fix: pass keystore inputs in re-sign step#18
Merged
thymikee merged 3 commits intocallstackincubator:mainfrom Dec 15, 2025
Merged
fix: pass keystore inputs in re-sign step#18thymikee merged 3 commits intocallstackincubator:mainfrom
thymikee merged 3 commits intocallstackincubator:mainfrom
Conversation
Contributor
|
Why not enable gradle properties setup in re-sign flow though? |
Contributor
Author
|
Re-sign is done by apksigner and passed arguments which gets data from signArchive options or fallback to default Not sure if this will read from properties without additional changes, looks like it doesn't touch gradle. |
This was referenced Dec 15, 2025
thymikee
reviewed
Dec 15, 2025
thymikee
approved these changes
Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keystore credentials weren't available since the gradle.properties setup is skipped in the re-sign flow. This caused builds using the re-sign flag to fall back to the default debug keystore.