Fix test deprecations and failures #994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix EntryCommandTest assertion for changed help output format - Fix ManagerFactoryTest dynamic property deprecations (PHP 8.4) - Add missing plugin classes for Blog and Migrator test plugins - Add proper assertions to PendingMigrationsMiddlewareTest risky tests
Member
Author
|
Maybe we skip those and instead release the new major. The if/else switches to have all tests green seem heavy. |
markstory
reviewed
Jan 12, 2026
Contributor
|
The test results are confusing! It was originally failing looking for |
Remove the assertion for 'migrations:</info>' as the help output format differs between PHP versions. The remaining assertions adequately verify the help output is displayed correctly.
The identity column syntax varies between CakePHP/database versions (SERIAL vs GENERATED BY DEFAULT AS IDENTITY). Update the tests to check for the key parts of the CREATE TABLE statement without being strict about the identity column syntax.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
EntryCommandTest::testExecuteHelpassertion for changed help output format (checks formigrations:instead ofAvailable Commands)ManagerFactoryTestdynamic property deprecations on PHP 8.4 by using local variables instead of dynamic class propertiesBlogandMigratortest plugins to resolve CakePHP 5.3 deprecation warningsPendingMigrationsMiddlewareTestrisky tests instead of relying on@doesNotPerformAssertionsTest plan