feat(http-client-mock): add new method to reset request builder#95
Closed
daFish wants to merge 1 commit intobrainbits:mainfrom
Closed
feat(http-client-mock): add new method to reset request builder#95daFish wants to merge 1 commit intobrainbits:mainfrom
daFish wants to merge 1 commit intobrainbits:mainfrom
Conversation
Member
Author
|
The issue was caused from my test setup. I couldn't reproduce it. Closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
$requestBuildersarray accumulated state across test runs with stale onMatch callbacks causing "Value of type null is not callable" errors.This change introduces a
reset-method to be called to reset the array.