Skip to content

Ad7173 nitpicks#2

Open
tatzelbrumm wants to merge 4 commits intobrain-duino:masterfrom
tatzelbrumm:AD7173_nitpicks
Open

Ad7173 nitpicks#2
tatzelbrumm wants to merge 4 commits intobrain-duino:masterfrom
tatzelbrumm:AD7173_nitpicks

Conversation

@tatzelbrumm
Copy link

This pull request removes three lines from the board file:

that may be useful for Eagle 7.4.0. In that case, they shouldn't be deleted. This pull request also adds a (Linux specific) eagle.epf project file that may be incompatible with others' versions.

Caught some missing dots and duplicate wire segments.
Added dummy value "." to devices where ERC requires value.
Color might be more informative value for LEDs.
It would be better to resolve I/O mapping conflicts than to approve ERC errors.

Signed-off-by: Christoph Maier <cm.hardware.software.elsewhere@gmail.com>
Signed-off-by: Christoph Maier <cm.hardware.software.elsewhere@gmail.com>
This is probably an artifact of me not using the auto router.
Separate commit, so it can be undone.

Signed-off-by: Christoph Maier <cm.hardware.software.elsewhere@gmail.com>
(may be platform specific, integrate with caution)

Signed-off-by: Christoph Maier <cm.hardware.software.elsewhere@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant