fix(content-explorer): Fix pdf infinite spinning loader issue

[jfox-box]

This is a fix for this user-reported issue: #4335

In Vite apps dev mode, opening a pdf would result in an infinite loading spinner. This was due to the cloneDeep method in ContentPreview attempting to assign readOnly properties in a PDFViewer object. We determined that it would be okay to pass the data object without cloning it, since consumers are unlikely to run into problems if they mutate this object, and it actually provides additional functionality if they want to call methods on the PDFViewer object.

[coderabbitai]

Walkthrough

Removed the lodash/cloneDeep dependency from the PreviewDialog component and modified the onLoad handler to pass data directly to the onPreview callback instead of passing a deep-cloned copy.

Changes

Cohort / File(s)	Summary
Dependency cleanup src/elements/common/preview-dialog/PreviewDialog.tsx	Removed cloneDeep import and updated onLoad handler to pass data directly without deep cloning, reducing external dependency usage

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

ready-to-merge

Suggested reviewers

• greg-in-a-box
• jpan-box

Poem

🐰 A clone's gone, the data flows free,
Lodash begone, one less import to see,
Direct and simple, efficient and clean,
The lightest refactor we've ever seen! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title mentions 'pdf infinite spinning loader issue' but the actual change removes cloneDeep from an onPreview call in PreviewDialog—the title does not accurately reflect the implemented solution.	Update the title to reflect the actual change, such as: 'fix(content-explorer): Remove cloneDeep from onPreview call' to match the PR's actual implementation.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check	✅ Passed	The PR description adequately explains the issue being fixed, references the related GitHub issue, and provides clear rationale for the change.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[mergify]

Merge Queue Status

✅ The pull request has been merged at d015724

This pull request spent 5 seconds in the queue, with no time running CI.
The checks were run in-place.

Required conditions to merge

• #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • fix(content-explorer): Fix pdf infinite spinning loader issue #4422
• #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • fix(content-explorer): Fix pdf infinite spinning loader issue #4422
• #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • fix(content-explorer): Fix pdf infinite spinning loader issue #4422
• branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
  • fix(content-explorer): Fix pdf infinite spinning loader issue #4422
• any of [🛡 GitHub branch protection]:
  • check-success = Summary
  • check-neutral = Summary
  • check-skipped = Summary
• any of [🛡 GitHub branch protection]:
  • check-success = lint_test_build
  • check-neutral = lint_test_build
  • check-skipped = lint_test_build
• any of [🛡 GitHub branch protection]:
  • check-success = license/cla
  • check-neutral = license/cla
  • check-skipped = license/cla
• any of [🛡 GitHub branch protection]:
  • check-success = lint_pull_request
  • check-neutral = lint_pull_request
  • check-skipped = lint_pull_request