Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Consuming ut as a named module using MSVC has compiler errors.
Solution:
stdas module.)import stdcapable export definitions implemented as a named module and not as a header unit.The proposed changes work with a downstream project that builds both the standard binary interface module (from
std.ixx) and ut (by renamingut.hpptout.ixx).Builds as:
The proposed changes don't build ut's own test infra, because none of the tests support
import std. How should I go about adding support for that?Issue: #558
Reviewers:
@kris-jusiak