Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Dec 17, 2015

Products are displayed immediately after domain name like: domain.com/Product_Name
For product categories, only the name of last level of category is displayed like: domain.com/category/pants
Removed concatenated IDs from product and category URLs .

Resolves: #20

@jholze
Copy link
Member

jholze commented Dec 17, 2015

@fshahy please check the travis issues.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe is not necessary the 'qweb' key if you actually don't have any template to load.

@kaerdsar
Copy link
Contributor

I tried to install the module but got this error:

ParseError: "Invalid view definition

Error details:
Element '<xpath expr="//a[@t-attf-href='/shop/product/#{ slug(line.product_id.product_tmpl_id) }']">' cannot be located in parent view

Error context:
View `Shopping Cart`
[view_id: 690, xml_id: n/a, model: n/a, parent_id: 667]
None" while parsing None:44, near
<data name="Shopping Cart" inherit_id="website_sale.cart">
            <xpath expr="//a[@t-attf-href='/shop/product/#{ slug(line.product_id.product_tmpl_id) }']" position="replace">
                <a t-attf-href="/#{ slug(line.product_id.product_tmpl_id) }">
                  <strong t-esc="line.product_id.with_context(display_default_code=False).display_name"/>
                </a>
            </xpath>
        </data>

@kaerdsar
Copy link
Contributor

kaerdsar commented Jan 6, 2016

Good. I could install the module fine.

I found two errors doing some testing:

Steps to reproduce:

  • Go to /shop in front end
  • Go to top right menu Content / New Product
  • Type a name for a new product and click Continue
  • You get page 404 because the system calls the product URL in the old way

Expected behavior:

  • After click in Continue the system should uses the new URL definition

2:
Steps to reproduce:

  • Create a product for sale
  • Go to /shop in front end and click in the product
  • Click Add to Cart in the product view
  • Click in the name of the product inside the shopping cart
  • You get page 404 because the system calls the product URL in the old way

Expected behavior:

  • After click in the name of the product the system should uses the new URL definition

Please, if you have a chance take a look at them.

@jholze jholze assigned ghost and unassigned kaerdsar Jan 6, 2016
@ghost
Copy link
Author

ghost commented Jan 7, 2016

@kaerdsar ok, I will check.

@rruebner rruebner assigned rruebner and unassigned ghost Jan 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants