Add the podspec and fix readme for React Native 0.60.0#6
Open
iamacup wants to merge 7 commits intoblend:masterfrom
Open
Add the podspec and fix readme for React Native 0.60.0#6iamacup wants to merge 7 commits intoblend:masterfrom
iamacup wants to merge 7 commits intoblend:masterfrom
Conversation
nunomago
reviewed
Jul 30, 2019
nunomago
left a comment
There was a problem hiding this comment.
Also trying to upgrade to RN 0.60 and stumbled upon this PR :) Kudos! 👍
Thanks so much :) Co-Authored-By: Nuno Oliveira <nuno.magoliveira@gmail.com>
Author
|
I have published my pull request on npm as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi
There are some updates needed to this repo to make it auto link with the new React Native 0.60.x
This pull will fix auto linking and make this error stop appearing:
EDIT:
I have published my pull request on npm as
react-native-screenshot-detectfor easy access to this because its been annoying me for awhile now... :)