Skip to content

Conversation

@itsadrago
Copy link
Contributor

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-31497

๐Ÿ“” Objective

We need to convert the remove password endpoint to use logic from the remove auth endpoint. Right now, we have some redundant logic, and in addition, by using the remove auth logic we have more time to convert all clients to use the remove auth endpoint so that we can eventually decommission the remove password endpoint.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@itsadrago itsadrago requested a review from a team as a code owner February 1, 2026 22:26
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2026

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 13fab8e5-b464-4751-9e68-8c86411cb4fe

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Feb 1, 2026

Codecov Report

โœ… All modified and coverable lines are covered by tests.
โœ… Project coverage is 56.06%. Comparing base (51aa419) to head (ac10335).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6929      +/-   ##
==========================================
- Coverage   60.01%   56.06%   -3.95%     
==========================================
  Files        1971     1971              
  Lines       87090    87083       -7     
  Branches     7759     7757       -2     
==========================================
- Hits        52266    48827    -3439     
- Misses      32928    36450    +3522     
+ Partials     1896     1806      -90     

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

๐Ÿš€ New features to boost your workflow:
  • โ„๏ธ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • ๐Ÿ“ฆ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants