Skip to content

Conversation

@itsadrago
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-31483

📔 Objective

If we ever have to disable the pm-19051-send-email-verificationflag after the email verification feature is released, we should not allow send access for existing sends that use email verification. Should we disable the flag, the owner of the send will need to remove email verification from the send and replace it with password protection or no protection at all.

📸 Screenshots

N/A

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@itsadrago itsadrago requested a review from a team as a code owner January 31, 2026 01:48
@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2026

Logo
Checkmarx One – Scan Summary & Details9e1cad33-bf7c-454d-96c3-6aab218f5f66

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Jan 31, 2026

Codecov Report

❌ Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.08%. Comparing base (51aa419) to head (35907f0).

Files with missing lines Patch % Lines
src/Api/Tools/Controllers/SendsController.cs 80.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6927      +/-   ##
==========================================
- Coverage   60.01%   56.08%   -3.94%     
==========================================
  Files        1971     1971              
  Lines       87090    87096       +6     
  Branches     7759     7761       +2     
==========================================
- Hits        52266    48844    -3422     
- Misses      32928    36443    +3515     
+ Partials     1896     1809      -87     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants