Skip to content

Conversation

@justindbaur
Copy link
Member

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-18069

📔 Objective

The server SDK deployed in the Billing container and everything is working great, so now we are introducing it to the rest of the services. To start it will only do telemetry but then we will do a migration to using feature flags through the server.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.00%. Comparing base (142ffe7) to head (98501de).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/Admin/Program.cs 0.00% 1 Missing ⚠️
src/Icons/Program.cs 0.00% 1 Missing ⚠️
src/Notifications/Program.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6915      +/-   ##
==========================================
+ Coverage   56.06%   60.00%   +3.93%     
==========================================
  Files        1968     1968              
  Lines       87049    87050       +1     
  Branches     7755     7755              
==========================================
+ Hits        48807    52233    +3426     
+ Misses      36433    32920    -3513     
- Partials     1809     1897      +88     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details2530549b-dec3-4f54-aad9-f9f902845d3f

Great job! No new security vulnerabilities introduced in this pull request

@justindbaur justindbaur marked this pull request as ready for review January 28, 2026 16:55
@justindbaur justindbaur requested review from a team as code owners January 28, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants