doc: added prerequisites to readme#221
Open
RockRockX2 wants to merge 1 commit intobitcoindevkit:masterfrom
Open
doc: added prerequisites to readme#221RockRockX2 wants to merge 1 commit intobitcoindevkit:masterfrom
RockRockX2 wants to merge 1 commit intobitcoindevkit:masterfrom
Conversation
notmandatory
requested changes
Sep 30, 2025
Member
notmandatory
left a comment
notmandatory
left a comment
There was a problem hiding this comment.
Thanks for the suggestion that will be helpful to new devs who haven't already installed gcc.
README.md
Outdated
| #### Prerequisites | ||
|
|
||
| Building BDK requires gcc. If you do not have this installed run: | ||
| ```` shell |
Member
There was a problem hiding this comment.
⛏️ needs to be three back-ticks and no space after.
Suggested change
| ```` shell | |
| ```shell |
Member
There was a problem hiding this comment.
This sub-section should also be placed at the beginning of the "Install bdk-cli" section.
Pull Request Test Coverage Report for Build 18167582568Details
💛 - Coveralls |
tvpeter
approved these changes
Oct 11, 2025
aagbotemi
reviewed
Oct 16, 2025
aagbotemi
left a comment
aagbotemi
left a comment
There was a problem hiding this comment.
Good job @RockRockX2, I left a suggestion for you to check.
| Building BDK requires gcc. If you do not have this installed run: | ||
| ``` shell | ||
| sudo apt-get install build-essential | ||
| ```` |
There was a problem hiding this comment.
It should be three back-ticks to close the code block.
Collaborator
There was a problem hiding this comment.
@RockRockX2, are you still available to fix this comment?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added gcc as a prerequisite.