BIP85: fix datetime string typo to align with UNIX Epoch time#1967
Merged
jonatack merged 8 commits intobitcoin:masterfrom Oct 15, 2025
Merged
BIP85: fix datetime string typo to align with UNIX Epoch time#1967jonatack merged 8 commits intobitcoin:masterfrom
jonatack merged 8 commits intobitcoin:masterfrom
Conversation
Geneis block time is correct in Unix time, but human readable version is off by 10 minutes. (Single digit typo)
jonatack
reviewed
Sep 17, 2025
Member
jonatack
left a comment
jonatack
left a comment
There was a problem hiding this comment.
ACK
Pinging @akarve and @scgbckbone for feedback.
jonatack
added
Pending acceptance
jonatack
reviewed
Sep 19, 2025
Member
jonatack
left a comment
jonatack
left a comment
There was a problem hiding this comment.
Thanks for updating. Feedback below.
Contributor
|
ACK |
Contributor
|
@jonatack anything blocking this merge? |
Co-authored-by: Jon Atack <jon@atack.com>
Co-authored-by: Jon Atack <jon@atack.com>
Co-authored-by: Jon Atack <jon@atack.com>
Contributor
Author
|
I just committed the suggested tweaks |
jonatack
reviewed
Oct 6, 2025
Member
|
ACK modulo the feedback. Feel free to squash the commits. |
jonatack
changed the title
jonatack
reviewed
Oct 6, 2025
jonatack
reviewed
Oct 6, 2025
Co-authored-by: Jon Atack <jon@atack.com>
jonatack
added
the
PR Author action required
Co-authored-by: Jon Atack <jon@atack.com>
Co-authored-by: Jon Atack <jon@atack.com>
Member
|
ACK eb7ad53 cc @akarve and @scgbckbone |
Contributor
|
re-ACK eb7ad53 |
jonatack
removed
Pending acceptance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Genesis block time is correct in Unix time, but human readable version is off by 10 minutes. (Single digit typo)
Basically this changes the fingerprint, so should be consistent so as to ensure compatibility between BIP85-GPG implementations.
(I am comparing my SeedSigner to Krux GPGap in this instance, the latter of which has gone with the human-readable time from the BIP whereas I went with Unix time and couldn't work out why the same input produced different results...)