Skip to content

Restore direct imports, and add named export for ESM htmx extension#121

Merged
botandrose merged 1 commit intomainfrom
import-idiomorph-htmx
Feb 20, 2025
Merged

Restore direct imports, and add named export for ESM htmx extension#121
botandrose merged 1 commit intomainfrom
import-idiomorph-htmx

Conversation

@botandrose
Copy link
Collaborator

  1. Fixes a regression in v0.7 where one could no longer import dist paths, e.g. import "idiomorph/dist/idiomorph.esm.js"
  2. Adds an official export path for Idiomorph + htmx extension: import "idiomorph/htmx"

Closes #119
Closes #38

@botandrose
Copy link
Collaborator Author

@MichaelWest22 Can you take a look at this branch with your local webpack and vite setup, and verify I didn't screw it up? Note that you'll need to run npm run dist to generate the ESM file targeted by the idiomorph/htmx export path.

Copy link
Collaborator

@MichaelWest22 MichaelWest22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah did a quick test in webpack and vite and it seems to be working fine

@botandrose botandrose merged commit e64f139 into main Feb 20, 2025
12 checks passed
@botandrose botandrose deleted the import-idiomorph-htmx branch February 20, 2025 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trouble getting Idiomorph Setup w/ Django + Webpack htmx extension without globals

3 participants