Merged
Conversation
bep
reviewed
Jan 17, 2026
lib/config.go
Outdated
| cfg.SourcePath = filepath.Clean(cfg.SourcePath) | ||
|
|
||
| // Resolve symlinks | ||
| { |
Owner
There was a problem hiding this comment.
This is all fine, except this indented code block -- which I can see make sense in some situations, but not for a 3-4 line block like this.
Contributor
Author
There was a problem hiding this comment.
The only reason I did this is to scope "err" to avoid variable shadowing with line 263. I've removed the code block and altered line 263 so that it compiles. Let me know if you'd prefer a different approach
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #516, the current implementation fails when
-sourcereceives a symlink directory. In this PR we solve this by converting symlinks to realpaths when the config is normalized.Limitations
This change only converts the value of
-sourceto a resolved path. As a result, passing a directory OR symlink directory to-sourcewill behave as expected. However, we leave the walk logic in deployer.go untouched. This means that if-sourcecontains nested symlinks they will not be supported. In truth I feel this is fine, not only is this the current behavior of s3deploy, but likely out of scope for this change as we'd need to recursively walk symlinks and maintain a relationship between the symlinked paths and the original-sourceroot directory.Backwards compatability
Should impact no existing flows, just adds
-sourcesymlink support.Example / How I tested this