fix: use stream_to as owner for async requests (#646) #816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When making async requests with a stream_to option, the connection owner is now set to the stream_to process instead of the caller. This ensures the connection lifecycle is tied to the actual message recipient. - If stream_to dies, the connection will be properly terminated - If the original caller dies but stream_to is still alive, the connection continues to work - Backward compatible: when stream_to equals the caller, behavior is unchanged The ownership change happens atomically inside the connection process when starting the async request, avoiding any race conditions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
stream_tooption, the connection owner is now set to the stream_to process instead of the caller