allow XCLASSing for Bednarik\Cooluri\Core\Translate#51
allow XCLASSing for Bednarik\Cooluri\Core\Translate#51ferbar wants to merge 1 commit intobednee:masterfrom
Conversation
|
This is core class, I don't think it's a good idea to xclass it. Why do you need it? |
|
would need this too. whenever we need to extend the functionality and options of cooluri that cannot be done through the config file. |
|
What kind of functionality you need? Could others use this functionality? If so, how about making it part of the core, just raise a pull request and I will review the code.
Jan
Odesláno z TypeApp
2. 3. 2017 16:43, 16:43, Andi <notifications@github.com> napsal/a:
…would need this too. whenever we need to extend the functionality and
options of cooluri that cannot be done through the config file.
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#51 (comment)
|
|
I going through some diffs right now :)
I am not sure, how useful this changes would be to the public. ( thus i agree a prompt in the backend would help everyone ;) ) We are working with cooluri for several years now and those changes where made due to customers requests. We patched cooluri on our side to enable those changes, but having more options in extending it using a proper "typo3" way would be appreciated. |
h4de5
left a comment
There was a problem hiding this comment.
I just notice, that i didn't give an approvement here. the changes will not interfere with any existing installation, only opening the extension for custom modifications.
No description provided.