Skip to content

Conversation

@Dark-Brain07
Copy link

What changed? Why?

  • Updated validateBasenameAvatarFile to be asynchronous: Implemented aspect ratio validation using createImageBitmap to ensure uploaded avatars are roughly square (ratio 0.8 - 1.25), fulfilling a TODO in usernames.ts.
  • Updated UsernameAvatarField: Refactored the component to handle the asynchronous nature of the validation function, ensuring proper state management during validation.
  • Cleaned up Footer: Removed a stale // TODO: add discord link comment in Footer.tsx as the link was already present.

Notes to reviewers

  • The validateBasenameAvatarFile function was converted to async to allow for image bitmap creation, which is necessary for checking dimensions.
  • useEffect in UsernameAvatarField now includes a mounted check to prevent state updates on unmounted components during the async validation.

How has it been tested?

  • Manual verification of logic correctness for async validation handling.
  • Confirmed Footer link presence visually in code.

Have you tested the following pages?

BaseWeb

  • base.org (Footer change)
  • base.org/names
  • base.org/builders
  • base.org/ecosystem
  • base.org/name/jesse
  • base.org/manage-names
  • base.org/resources

@vercel
Copy link

vercel bot commented Jan 22, 2026

@Dark-Brain07 is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall
Copy link
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/2
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants